Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NotificationConfiguration NuGet package version to 1.0.0-dev.20230216.1 to enable CODEOWNERS regex matcher everywhere #5488

Merged

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 16, 2023

Relevant Teams announcement on Engineering Systems channel

This PR is a follow-up to:

As in subject; the following PR gets deployed with this change:

As a result, all build failure notification recipients will be determined based on the new regex-based, wildcard-supporting CODEOWNERS matcher, as opposed to the obsolete prefix-based one.

As a result, after this PR is merged, the next run of the pipeline automation - build-failure-notification-subscriptions will change the build failure notification recipients.

The pipeline run that changed the failure recipients:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2196646&view=logs&j=ad5747fc-b58e-5e0d-2246-f6c6b542e026

Comment explaining how to interpret the log

Relevant tool doc is here:

https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/63/Subscribe-to-Notifications

Related work:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 16, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 16, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team February 16, 2023 22:16
@konrad-jamrozik konrad-jamrozik changed the title Update NotificationConfiguration NuGet package version to 1.0.0-dev.20230216.1 Update NotificationConfiguration NuGet package version to 1.0.0-dev.20230216.1 to enable CODEOWNERS regex matcher everywhere Feb 16, 2023
@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review February 16, 2023 22:18
@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 4e0fe68 into main Feb 16, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/update_packages_regex_notif_everywhere branch February 16, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants