-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Handle InvalidApiVersionParameter
on Empty ResourceGroup / Gracefully handle 400 errs
#1106
Comments
InvalidApiVersionParameter
InvalidApiVersionParameter
on Empty ResourceGroup / Gracefullt handle 400 errs
InvalidApiVersionParameter
on Empty ResourceGroup / Gracefullt handle 400 errsInvalidApiVersionParameter
on Empty ResourceGroup / Gracefully handle 400 errs
We should remove 'omitempty' from the types files for Resourcegroup from AzureSqlServer types. file and also other types if the issue exists. This will ensure that we catch the error if resourcegroup is not specified which causes this issue. |
@melonrush13 were you testing this in kind, or in an AKS cluster with webhooks enabled? This error definitely happens when I've filed an issue for the Go SDK folks since the SDK is supposed to do this check, but in the meantime I've updated the controller to check this manually and give a better error in #1232132 |
* Improve error when SQL server doesn't have RG specified - This fixes #1106. * Update all occurances of Resourcegroup to have validation - They should be required, min length 1, and matching the specified Regex. * Fix some tests * PR feedback
We should remove 'omitempty' from the types files for Resourcegroup from AzureSqlServer types. file and also other types if the issue exists. This will ensure that we catch the error if resourcegroup is not specified which causes this issue.
Describe the bug
The following error occurs for creating a V1Alpha1 azuresqlserver with an empty resource group or invalid named resourcegroup.
To Reproduce
Steps to reproduce the behavior:
k create -f config/samples/azure_v1alpha1_azuresqlserver.yaml
My Resource Group Name:
resourcegroup-azure-operators-mel
Expected behavior
Gracefully handle 400 errors (similarly to how Redis Cache handles future errs)
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: