Improve error when SQL server doesn't have RG specified #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
frodopwns,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
Porges
requested changes
Jun 23, 2020
pkg/resourcemanager/azuresql/azuresqlserver/azuresqlserver_reconcile.go
Outdated
Show resolved
Hide resolved
|
You could also put |
matthchr
force-pushed
the
feature/fix-bug-1106
branch
from
b327923 to
8e1a15f
Compare
|
I added some additional Kubebuilder validation |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This did get quite repetitive; we could define a |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jananivMS
reviewed
Jun 24, 2020
matthchr
force-pushed
the
feature/fix-bug-1106
branch
from
e866b82 to
5ccf665
Compare
Porges
previously approved these changes
Jun 24, 2020
theunrepentantgeek
previously approved these changes
Jun 25, 2020
jananivMS
reviewed
Jun 25, 2020
pkg/resourcemanager/azuresql/azuresqlserver/azuresqlserver_reconcile.go
Outdated
Show resolved
Hide resolved
matthchr
force-pushed
the
feature/fix-bug-1106
branch
from
5ccf665 to
7b1aacd
Compare
- They should be required, min length 1, and matching the specified
Regex.
matthchr
force-pushed
the
feature/fix-bug-1106
branch
from
7b1aacd to
185fb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1106
What this PR does / why we need it:
Improves ResourceGroup empty handling for SQL Server creation
Special notes for your reviewer:
None
Let me know if there should be a test here too.