Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad de-pluralizations #1454

Closed
Porges opened this issue Nov 10, 2020 · 1 comment · Fixed by #1586
Closed

Bad de-pluralizations #1454

Porges opened this issue Nov 10, 2020 · 1 comment · Fixed by #1586
Assignees
@theunrepentantgeek
Milestone
codegen-alpha-2

Comments

@Porges
Copy link
Member

Porges commented Nov 10, 2020

For example, “services” comes out as “servex”: gobuffalo/flect#49
@Porges Porges changed the title Bad pluralizations Bad de-pluralizations Nov 10, 2020
Porges referenced this issue in Azure/k8s-infra Nov 12, 2020
@Porges
Add tests for two more Storage resource types, and fixes to support (#…
3641fcf 
…320)

* Add create/delete tests for the `StorageAccountsBlobService` and `StorageAccountsBlobServicesContainer` resource types. 
* Attempt to make deployment more robust, if we deploy a second time and the deployment already exists. This could happen due to faults or spurious failures in patching resources.
  * TODO: We need to check the existing deployment against spec and delete/recreate it if it is different?
*  Handle authentication configuration errors as early as possible; the `autorest` library does not check this and will give back an authorizer that does not work.
* Added temporary fix for #319.
* Fix bad log message in one of the matchers.
* Only save recording for a test when it is successful. This makes it easier to develop when trying to fix a test.

## Outstanding items

We need to think about how to handle resources like `StorageAccountsBlobService` better. It _must_ be named `"default"` to work but this is not enforced at the moment.

One idea is that we could merge this into the `StorageAccount` resource type so that it can be configured there, and the controller takes care of creating it separately.

Another issue is that the name is not going to be unique in Kubernetes. For resources with an owner we might need to scope the name under the owner name, but I’m not sure that this is possible; the object is created in Kubernetes before we can touch the name. The user can set AzureName to "default" and Name to something else but this is not obvious.

I opened an issue for this here: #324
@Porges Porges transferred this issue from Azure/k8s-infra May 14, 2021
@theunrepentantgeek theunrepentantgeek added this to the codegen-alpha-1 milestone May 17, 2021
@Porges
Copy link
Member Author

Porges commented Jun 21, 2021

Some should be fixed now: gobuffalo/flect#50

@Porges Porges mentioned this issue Jun 21, 2021
Merged
Porges added a commit that referenced this issue Jun 22, 2021
@Porges
Update flect and code (#1586)
e844e18 
Closes #1454.

**What this PR does / why we need it**:

Flect has fixes in the latest version, so we don’t need so many overrides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theunrepentantgeek theunrepentantgeek

Labels
None yet
Projects
None yet
Milestone
codegen-alpha-2
Development

Successfully merging a pull request may close this issue.

Update flect to v0.2.3 and code to match Azure/azure-service-operator
2 participants
@Porges @theunrepentantgeek