Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flect to v0.2.3 and code to match #1586

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Update flect to v0.2.3 and code to match #1586

merged 2 commits into from
Jun 22, 2021

Conversation

Porges
Copy link
Member

@Porges Porges commented Jun 21, 2021

Closes #1454.

What this PR does / why we need it:

Flect has fixes in the latest version, so we don’t need so many overrides.

@codecov-commenter
Copy link

Codecov Report

Merging #1586 (ba66cc0) into master (0e4cd9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1586   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         182      182           
  Lines       11876    11876           
=======================================
  Hits         7539     7539           
  Misses       3669     3669           
  Partials      668      668           
Impacted Files Coverage Δ
hack/generator/pkg/astmodel/type_name.go 60.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4cd9c...ba66cc0. Read the comment docs.

@Porges Porges changed the title Update flect to v0.2.3 and code Update flect to v0.2.3 and code to match Jun 21, 2021
@Porges Porges merged commit e844e18 into master Jun 22, 2021
@Porges Porges deleted the flect-update branch June 22, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad de-pluralizations
4 participants