Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support collection of SecretReferences #3435

Closed
super-harsh opened this issue Oct 16, 2023 · 2 comments · Fixed by #3744
Closed

Support collection of SecretReferences #3435

super-harsh opened this issue Oct 16, 2023 · 2 comments · Fixed by #3744
Assignees
@matthchr
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug)
Milestone
v2.6.0

Comments

@super-harsh
Copy link
Collaborator

Describe the current behavior

Currently isSecret field for the generator, only lets us specify the string fields to mark as a secret reference.

Describe the improvement

We should be able to mark collections(map, slice) as a secret reference

Additional context

Prerequisite for #2934
@super-harsh super-harsh added this to the v2.4.0 milestone Oct 16, 2023
@super-harsh super-harsh added the high-priority Issues we intend to prioritize (security, outage, blocking bug) label Oct 16, 2023
@theunrepentantgeek theunrepentantgeek changed the title Support collection of SecretRefereces Support collection of SecretReferences Oct 16, 2023
@matthchr matthchr self-assigned this Oct 16, 2023
@super-harsh super-harsh mentioned this issue Nov 7, 2023
Merged
@matthchr matthchr modified the milestones: v2.4.0, v2.5.0 Nov 10, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@super-harsh super-harsh mentioned this issue Dec 15, 2023
Merged
2 tasks
@tomkerkhove
Copy link
Member

I see it is mentioned that this is a requirement for #3528, but it has been merged.

Does that mean that this has been completed, @matthchr? I presume it is not?

@matthchr
Copy link
Member

It's not done, we worked around it in #3528.

I'm working on this now though.

@theunrepentantgeek theunrepentantgeek mentioned this issue Jan 23, 2024
Closed
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jan 25, 2024
@matthchr
Support []string and map[string]string secret properties
d2e0adc 
This resolves Azure#3435.

[]string is transformed into []genruntime.SecretReference.

map[string]string is transformed into a new type
genruntime.SecretCollectionReference. Unlike genruntime.SecretReference,
SecretCollectionReference refers to an entire secret rather than only
some parts of it. This is required to keep the keys of the map secret
too. It also presents a slightly cleaner user interface than
map[string]genruntime.SecretReference would have.
@matthchr matthchr mentioned this issue Jan 25, 2024
Merged
3 tasks
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jan 26, 2024
@matthchr
Support []string and map[string]string secret properties
9596d05 
This resolves Azure#3435.

[]string is transformed into []genruntime.SecretReference.

map[string]string is transformed into a new type
genruntime.SecretCollectionReference. Unlike genruntime.SecretReference,
SecretCollectionReference refers to an entire secret rather than only
some parts of it. This is required to keep the keys of the map secret
too. It also presents a slightly cleaner user interface than
map[string]genruntime.SecretReference would have.
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jan 26, 2024
@matthchr
Support []string and map[string]string secret properties
08a03d2 
This resolves Azure#3435.

[]string is transformed into []genruntime.SecretReference.

map[string]string is transformed into a new type
genruntime.SecretCollectionReference. Unlike genruntime.SecretReference,
SecretCollectionReference refers to an entire secret rather than only
some parts of it. This is required to keep the keys of the map secret
too. It also presents a slightly cleaner user interface than
map[string]genruntime.SecretReference would have.
@matthchr matthchr mentioned this issue Jan 26, 2024
Merged
3 tasks
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jan 30, 2024
@matthchr
Support []string and map[string]string secret properties
687250f 
This resolves Azure#3435.

[]string is transformed into []genruntime.SecretReference.

map[string]string is transformed into a new type
genruntime.SecretCollectionReference. Unlike genruntime.SecretReference,
SecretCollectionReference refers to an entire secret rather than only
some parts of it. This is required to keep the keys of the map secret
too. It also presents a slightly cleaner user interface than
map[string]genruntime.SecretReference would have.
github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2024
@matthchr
Support []string and map[string]string secret properties (#3744)
27e6a82 
This resolves #3435.

[]string is transformed into []genruntime.SecretReference.

map[string]string is transformed into a new type
genruntime.SecretCollectionReference. Unlike genruntime.SecretReference,
SecretCollectionReference refers to an entire secret rather than only
some parts of it. This is required to keep the keys of the map secret
too. It also presents a slightly cleaner user interface than
map[string]genruntime.SecretReference would have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthchr matthchr

Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug)
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Support []string and map[string]string secret properties matthchr/azure-service-operator
4 participants
@theunrepentantgeek @tomkerkhove @matthchr @super-harsh