Add support for Microsoft.KubernetesConfiguration/extensions #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
|
TODO: Need to add sample and record sample test |
super-harsh
force-pushed
the
feature/k8s-extension
branch
from
71bd0c4 to
c0c4203
Compare
matthchr
reviewed
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
===========================================
- Coverage 54.02% 52.84% -1.18%
===========================================
Files 1578 1285 -293
Lines 657622 401929 -255693
===========================================
- Hits 355267 212404 -142863
+ Misses 244736 158918 -85818
+ Partials 57619 30607 -27012 ☔ View full report in Codecov by Sentry. |
super-harsh
force-pushed
the
feature/k8s-extension
branch
from
4724666 to
e44fc1e
Compare
super-harsh
force-pushed
the
feature/k8s-extension
branch
from
365e033 to
df81002
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* Needed a fix due to CLI updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2934
What this PR does / why we need it:
This PR adds support for Microsoft.KubernetesConfiguration/extensions.
Also includes a generator fix to identify the extension types
Special notes for your reviewer:
Removing the
ConfigurationProtectedSettingsconfiguration from the resource for now as it's dependent on #3435 being resolved. Once resolved, we can revert this field to be on the resource.