Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Move non string helper functions out of stringhelper.go #414

Closed
1 task
jananivMS opened this issue Oct 24, 2019 · 1 comment · Fixed by #992
Closed
1 task

Task: Move non string helper functions out of stringhelper.go #414

jananivMS opened this issue Oct 24, 2019 · 1 comment · Fixed by #992
Assignees
@melonrush13

Comments

@jananivMS
Copy link
Contributor

pkg/helper/stringhelper.go has some functions that are not string related. Need to remove them out to a more logical place

**Done criteria **
This is the "done" criteria for this task

  • stringhelper.go only has helper functions related to strings
@frodopwns
Copy link
Contributor

looks like IsBeingDeleted still needs to be removed

@jananivMS jananivMS added the S label Apr 20, 2020
@melonrush13 melonrush13 mentioned this issue Apr 23, 2020
Merged
2 tasks
@melonrush13 melonrush13 self-assigned this Apr 23, 2020
Porges pushed a commit that referenced this issue May 11, 2021
@matthchr
Fix crossplane config (#414)
3496810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melonrush13 melonrush13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes non string helper functions out of stringhelpers.go (IsBeingDeleted)
3 participants
@frodopwns @melonrush13 @jananivMS