Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes non string helper functions out of stringhelpers.go (IsBeingDeleted) #992

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Removes non string helper functions out of stringhelpers.go (IsBeingDeleted) #992

merged 5 commits into from
Apr 24, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Apr 23, 2020

Closes #414

What this PR does / why we need it:
Stringhelpers.go contains string helper functions. IsBeingDeleted is not a string helper function and is no longer being used. This PR removes the function from the code base.

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@melonrush13
Copy link
Contributor Author

@cnadolny I think you are in the process of removing Azure Data Lake operator right now if I'm correct? I wanted to tag you in this just so you are aware I deleted some functions which might touch files you are looking at!

@melonrush13 melonrush13 changed the title Removes non string helper functions out of string helper (IsBeingDeleted) Removes non string helper functions out of stringhelpers.go (IsBeingDeleted) Apr 23, 2020
Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WilliamMortlMicrosoft
Copy link
Contributor

the conflicts are that those files are gone

@WilliamMortlMicrosoft
Copy link
Contributor

I'm re-running the pipeline, but observed this:

--- FAIL: TestMySQLHappyPath (1057.03s)
    helpers.go:278: 
        	Error Trace:	helpers.go:278
        	            				helpers.go:211
        	            				mysql_combined_test.go:36
        	Error:      	Expected nil, but got: &errors.errorString{s:"Expected: \n\t\t\t\t\tStatus.Message to contain successfully provisioned\n\t\t\t\t\tStatus.Provisioned to be true\n\t\t\t\tActual:\n\t\t\t\t\tMessage: 'mysql.ServersCreateFuture: asynchronous operation has not completed'\n\t\t\t\t\tProvisioned: false\n\t\t\t\t"}
        	Test:       	TestMySQLHappyPath
        	Messages:   	wait for *v1alpha1.MySQLServer to provision

@melonrush13
Copy link
Contributor Author

I'm re-running the pipeline, but observed this:

--- FAIL: TestMySQLHappyPath (1057.03s)
    helpers.go:278: 
        	Error Trace:	helpers.go:278
        	            				helpers.go:211
        	            				mysql_combined_test.go:36
        	Error:      	Expected nil, but got: &errors.errorString{s:"Expected: \n\t\t\t\t\tStatus.Message to contain successfully provisioned\n\t\t\t\t\tStatus.Provisioned to be true\n\t\t\t\tActual:\n\t\t\t\t\tMessage: 'mysql.ServersCreateFuture: asynchronous operation has not completed'\n\t\t\t\t\tProvisioned: false\n\t\t\t\t"}
        	Test:       	TestMySQLHappyPath
        	Messages:   	wait for *v1alpha1.MySQLServer to provision

I got this same err on my cosmos API change too.. :/ I'll paste it to Erin

Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HYFR

@melonrush13 melonrush13 merged commit 1b16603 into Azure:master Apr 24, 2020
@melonrush13 melonrush13 deleted the stringhelper branch April 24, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Move non string helper functions out of stringhelper.go
2 participants