-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes non string helper functions out of stringhelpers.go (IsBeingDeleted) #992
Conversation
@cnadolny I think you are in the process of removing Azure Data Lake operator right now if I'm correct? I wanted to tag you in this just so you are aware I deleted some functions which might touch files you are looking at! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the conflicts are that those files are gone |
…perator into stringhelper
I'm re-running the pipeline, but observed this:
|
I got this same err on my cosmos API change too.. :/ I'll paste it to Erin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HYFR
Closes #414
What this PR does / why we need it:
Stringhelpers.go contains string helper functions. IsBeingDeleted is not a string helper function and is no longer being used. This PR removes the function from the code base.
Special notes for your reviewer:
How does this PR make you feel:
If applicable: