Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Remove logger from the resource manager clients #800

Closed
9 tasks done
jananivMS opened this issue Mar 23, 2020 · 1 comment · Fixed by #817, #832, #845, #846 or #850
Closed
9 tasks done

Task: Remove logger from the resource manager clients #800

jananivMS opened this issue Mar 23, 2020 · 1 comment · Fixed by #817, #832, #845, #846 or #850
Assignees

Comments

@jananivMS
Copy link
Contributor

jananivMS commented Mar 23, 2020

Many of the resource managers under pkg/resourcemanager still have loggers/Telemetry. We should remove the loggers completely from these resource managers so we have logging only from the higher levels.

**Done criteria **
This is the "done" criteria for this task

grep -r "logr.Logger" ./pkg/resourcemanager/ -l

  • None of the resource managers have loggers or Telemetry. There is no logging at the lower levels

  • Postgre SQL

  • Azure SQL

  • event Hubs

  • Key Vaults

  • Redis Cache

  • Vnet

  • API management

  • application insights

(Branched from #432)

@jananivMS
Copy link
Contributor Author

@buhongw7583c Hong - you can refer to this client here for an example that does not have the logger
https://github.com/Azure/azure-service-operator/tree/master/pkg/resourcemanager/azuresql/azuresqlvnetrule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment