Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#task800#RemoveLoggerFromKeyVault #846

Merged
merged 3 commits into from
Mar 31, 2020
Merged

#task800#RemoveLoggerFromKeyVault #846

merged 3 commits into from
Mar 31, 2020

Conversation

buhongw7583c
Copy link
Contributor

Closes #[issue number]

What this PR does / why we need it:
Part4 of #800, to remove Logger from KeyVault under resource manager.

Special notes for your reviewer:
Before the change, below files contains the Logger parameter.

grep -r "logr.Logger" ./pkg/resourcemanager/keyvaults/ -l
./pkg/resourcemanager/keyvaults//keyvault.go

After the change,

grep -r "logr.Logger" ./pkg/resourcemanager/keyvaults/ -l

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

WilliamMortlMicrosoft
WilliamMortlMicrosoft approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created and delted keyvault

@buhongw7583c buhongw7583c merged commit b9abb35 into Azure:master Mar 31, 2020
@buhongw7583c buhongw7583c deleted the task#800#RmLoggerKeyvault branch March 31, 2020 08:48
@buhongw7583c buhongw7583c linked an issue Apr 1, 2020 that may be closed by this pull request
Task: Remove logger from the resource manager clients #800
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamMortlMicrosoft WilliamMortlMicrosoft WilliamMortlMicrosoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Remove logger from the resource manager clients
2 participants
@buhongw7583c @WilliamMortlMicrosoft