Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#task800#removeLoggerFromEventHub #845

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

buhongw7583c
Copy link
Contributor

Closes #800

What this PR does / why we need it:
Part3 for task#800, to remove Logger from eventHub under resource manager.

Special notes for your reviewer:
Before the change, the files under eventhugs with 'Logger' parameters.

grep -r "logr.Logger" ./pkg/resourcemanager/eventhubs/ -l
./pkg/resourcemanager/eventhubs//consumergroup.go
./pkg/resourcemanager/eventhubs//namespace.go

After the change,

grep -r "logr.Logger" ./pkg/resourcemanager/eventhubs/ -l

It is not feasible to test the modified code though, tested the create/delete eventhub namespace, eventhub and consumergroup.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created and deleted EventHub

@buhongw7583c buhongw7583c merged commit 33d6416 into Azure:master Mar 31, 2020
@buhongw7583c buhongw7583c deleted the task#800#RMloggerEventhug branch March 31, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Remove logger from the resource manager clients
2 participants