doc change to work with aad pod id breaking change #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodopwns
suggested changes
May 7, 2020
docs/managedidentity.md
Outdated
| @@ -57,7 +57,7 @@ Perform these steps to use Managed Identity instead of Service Principal authent | |||
| namespace: azureoperator-system | |||
| spec: | |||
| type: 0 | |||
| ResourceID: /subscriptions/<subid>/resourcegroups/<resourcegroup>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<name> | |||
| resourceID: /subscriptions/<subid>/resourcegroups/<resourcegroup>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<name> | |||
| ClientID: <Managed Identity clientId> | |||
There was a problem hiding this comment.
good catch! not sure how I missed this! Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that AAD pod identity 1.6 has a breaking change with casing for the fields - https://github.com/Azure/aad-pod-identity#v160-breaking-change
Updating the doc to make sure this is updated so we can keep Managed identity docs working well