Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc change to work with aad pod id breaking change #1028

Merged
merged 4 commits into from
May 7, 2020
Merged

doc change to work with aad pod id breaking change #1028

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccb6f52
change to accomodate aad pod id breaking change
jananivMS May 6, 2020
23f16e2
Merge branch 'master' into midocupdate1
jananivMS May 6, 2020
ff10f17
missed field
jananivMS May 7, 2020
acc1fb6
Merge branch 'master' into midocupdate1
jananivMS May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/managedidentity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Perform these steps to use Managed Identity instead of Service Principal authent
namespace: azureoperator-system
spec:
type: 0
ResourceID: /subscriptions/<subid>/resourcegroups/<resourcegroup>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<name>
resourceID: /subscriptions/<subid>/resourcegroups/<resourcegroup>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<name>
ClientID: <Managed Identity clientId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! not sure how I missed this! Fixed

```

Expand All @@ -68,6 +68,6 @@ Perform these steps to use Managed Identity instead of Service Principal authent
name: aso-identity-binding
namespace: azureoperator-system
spec:
AzureIdentity: <a-idname>
Selector: aso_manager_binding
azureIdentity: <a-idname>
selector: aso_manager_binding
```