Remove use of satori uuid package #1306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
requested review from
babbageclunk,
davefellows,
frodopwns,
jananivMS,
matthchr,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
Porges
commented
Oct 27, 2020
| @@ -4,7 +4,6 @@ go 1.13 | |||
|
|
|||
| require ( | |||
| github.com/Azure/azure-sdk-for-go v44.0.0+incompatible | |||
| github.com/Azure/go-autorest v14.2.0+incompatible // indirect | |||
There was a problem hiding this comment.
these other removals happened due to go mod tidy
|
@matthchr what's the test coverage like? are we safe? |
|
@Porges the test coverage isn't as good as it could/should be - but it's what we have. I see this package is used by us in azuresqlmanageduser and keyvault. We definitely have tests for KeyVault and from what I can see at least |
|
I might hold off on this for a bit while Azure SDK for Go updates their references. Then I shouldn’t need to do mod rewriting. |
|
Tracking this PR in autorest: Azure/autorest.go#520 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1291. Had to fix this with a go.mod rewrite as there are dependencies like the Go Azure SDK that depend on the satori package directly.