Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of satori/uuid package via upgrading azure-sdk-for-go #1484

Merged
merged 4 commits into from
May 18, 2021

Conversation

Porges
Copy link
Member

@Porges Porges commented May 17, 2021

Closes #1291, closes #1143, closes #1306 (via obsoletion).

go-autorest also updated as azure-sdk-for-go required a newer version.

What this PR does / why we need it:

https://github.com/satori/go.uuid has an open security vulnerability. The new azure-sdk-for-go (as of v53) removes the dependency on satori/go.uuid (Azure/azure-sdk-for-go#14283, Azure/azure-sdk-for-go#3158).

Any direct references have been replaced by gofrs/uuid, which is API-compatible.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #1484 (c52d3a4) into master (b4dd8c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   62.13%   62.13%           
=======================================
  Files         161      161           
  Lines       10695    10695           
=======================================
  Hits         6645     6645           
  Misses       3414     3414           
  Partials      636      636           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dd8c0...c52d3a4. Read the comment docs.

@matthchr
Copy link
Member

I wonder if we need to check our linter settings since this wasn't caught and is a lintable error, I think?

@Porges Porges merged commit 6501ba1 into master May 18, 2021
@Porges Porges deleted the azure-sdk-upgrade branch May 18, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using a different UUID library Update autorest and azure-sdk-for-go?
5 participants