Update CRDs to v1 apiversion #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Force preserveUnknownFields to false.
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
|
I tested upgrade on a simple cluster that already had the old CRDs deployed into it. New CRD application went fine. I don't think we need to worry about having existing resources doing things in the cluster (mine didn't have much). |
babbageclunk
approved these changes
May 9, 2021
matthchr
force-pushed
the
feature/updated-crd-versions
branch
from
f46d41f to
652a32e
Compare
matthchr
force-pushed
the
feature/updated-crd-versions
branch
from
652a32e to
1ac5e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1270.
What this PR does / why we need it: