Update patch targets to CRD v1 #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
requested review from
davefellows,
matthchr,
Porges and
theunrepentantgeek
as code owners
matthchr
approved these changes
May 12, 2021
There was a problem hiding this comment.
Thanks for catching and fixing this so quickly @babbageclunk
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
=======================================
Coverage 62.08% 62.08%
=======================================
Files 159 159
Lines 10594 10594
=======================================
Hits 6577 6577
Misses 3392 3392
Partials 625 625 Continue to review full report at Codecov.
|
|
Yay, thanks for fixing this @Porges! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These were missed when the CRD generation was updated to produce v1 (#1424). Weirdly there's nothing in the CI pipeline that uses the patched CRDs - I'll add an issue for that.
How does this PR make you feel:
