Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create testcases package #1557

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

To reduce clutter in the astmodel package, creates a new package testcases. Currently we have only a single test case, but that number is going to grow as a part of the implementation for storage variants, so it makes sense to break it out now.

Also fixes a bug where test cases were not being generated for Resources because the interface wasn't being implemented.

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #1557 (d8d56d1) into master (90da966) will decrease coverage by 0.01%.
The diff coverage is 3.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage   63.47%   63.46%   -0.02%     
==========================================
  Files         176      176              
  Lines       11694    11697       +3     
==========================================
  Hits         7423     7423              
- Misses       3607     3610       +3     
  Partials      664      664              
Impacted Files Coverage Δ
hack/generator/pkg/astmodel/object_type.go 73.03% <ø> (ø)
hack/generator/pkg/astmodel/resource_type.go 73.58% <0.00%> (-0.85%) ⬇️
...ack/generator/pkg/astmodel/test_file_definition.go 0.00% <0.00%> (ø)
...g/testcases/object_type_serialization_test_case.go 2.08% <1.69%> (ø)
.../codegen/pipeline_json_serialization_test_cases.go 80.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90da966...d8d56d1. Read the comment docs.

@theunrepentantgeek theunrepentantgeek merged commit b10a226 into master Jun 14, 2021
@theunrepentantgeek theunrepentantgeek deleted the feature/test-cases-package branch June 14, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants