Create testcases package

hack/generator/pkg/astmodel/object_type.go

@@ -10,9 +10,10 @@ import (
 	"sort"
 	"strings"
 
-	"github.com/Azure/azure-service-operator/hack/generator/pkg/astbuilder"
 	"github.com/dave/dst"
 	"github.com/pkg/errors"
+
+	"github.com/Azure/azure-service-operator/hack/generator/pkg/astbuilder"
 )
 
 // ObjectType represents an (unnamed) object type
@@ -36,6 +37,9 @@ var _ PropertyContainer = &ObjectType{}
 // Ensure ObjectType implements the FunctionContainer interface correctly
 var _ FunctionContainer = &ObjectType{}
 
+// Ensure ObjectType implements the TestCaseContainer interface correctly
+var _ TestCaseContainer = &ObjectType{}
+
 // NewObjectType is a factory method for creating a new ObjectType
 func NewObjectType() *ObjectType {
 	return &ObjectType{

hack/generator/pkg/astmodel/resource_type.go

@@ -131,6 +131,9 @@ var _ PropertyContainer = &ResourceType{}
 // Ensure ResourceType implements the FunctionContainer interface correctly
 var _ FunctionContainer = &ResourceType{}
 
+// Ensure ResourceType implements the TestCaseContainer interface correctly
+var _ TestCaseContainer = &ResourceType{}
+
 // SpecType returns the type used for specification
 func (resource *ResourceType) SpecType() Type {
 	return resource.spec
@@ -207,6 +210,16 @@ func (resource *ResourceType) WithTestCase(testcase TestCase) *ResourceType {
 	return result
 }
 
+// TestCases returns a new slice containing all the test cases associated with this resource
+func (resource *ResourceType) TestCases() []TestCase {
+	var result []TestCase
+	for _, tc := range resource.testcases {
+		result = append(result, tc)
+	}
+
+	return result
+}
+
 // AsType always panics because a resource has no direct AST representation
 func (resource *ResourceType) AsType(_ *CodeGenerationContext) dst.Expr {
 	panic("a resource cannot be used directly as a type")

hack/generator/pkg/astmodel/test_case.go

@@ -27,6 +27,8 @@ type TestCase interface {
 	Equals(f TestCase) bool
 }
 
-type TestCaseDefiner interface {
+// TestCaseContainer represents types that can contain test cases
+// These types allow us to generate tests to verify the generated code does the right thing
+type TestCaseContainer interface {
 	TestCases() []TestCase
 }

hack/generator/pkg/astmodel/test_file_definition.go

@@ -43,7 +43,7 @@ func (file *TestFileDefinition) AsAst() (*dst.File, error) {
 	// Emit all test cases:
 	var testcases []dst.Decl
 	for _, s := range file.definitions {
-		definer, ok := s.Type().(TestCaseDefiner)
+		definer, ok := s.Type().(TestCaseContainer)
 		if !ok {
 			continue
 		}
@@ -90,7 +90,7 @@ func (file *TestFileDefinition) generateImports() *PackageImportSet {
 	var requiredImports = NewPackageImportSet()
 
 	for _, s := range file.definitions {
-		definer, ok := s.Type().(TestCaseDefiner)
+		definer, ok := s.Type().(TestCaseContainer)
 		if !ok {
 			continue
 		}

hack/generator/pkg/codegen/pipeline_json_serialization_test_cases.go

@@ -9,6 +9,8 @@ import (
 	"context"
 
 	"github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel"
+	"github.com/Azure/azure-service-operator/hack/generator/pkg/testcases"
+
 	kerrors "k8s.io/apimachinery/pkg/util/errors"
 )
 
@@ -62,7 +64,7 @@ func (s *objectSerializationTestCaseFactory) AddTestTo(def astmodel.TypeDefiniti
 func (s *objectSerializationTestCaseFactory) injectTestCase(
 	_ *astmodel.TypeVisitor, objectType *astmodel.ObjectType, ctx interface{}) (astmodel.Type, error) {
 	name := ctx.(astmodel.TypeName)
-	testcase := astmodel.NewObjectSerializationTestCase(name, objectType, s.idFactory)
+	testcase := testcases.NewObjectSerializationTestCase(name, objectType, s.idFactory)
 	result := objectType.WithTestCase(testcase)
 	return result, nil
 }