Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to astbuilder #1613

Merged
merged 4 commits into from
Jul 4, 2021
Merged

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Jul 1, 2021

What this PR does / why we need it:

Pulls in some improvements to the astbuilder package.

Harvested from PR #1533

How does this PR make you feel:
gif

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #1613 (0dffff5) into master (2578fbe) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
- Coverage   62.91%   62.90%   -0.02%     
==========================================
  Files         187      187              
  Lines       12355    12362       +7     
==========================================
+ Hits         7773     7776       +3     
- Misses       3898     3902       +4     
  Partials      684      684              
Impacted Files Coverage Δ
hack/generator/pkg/astbuilder/builder.go 84.69% <80.95%> (-1.67%) ⬇️
hack/generator/pkg/astbuilder/calls.go 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2578fbe...0dffff5. Read the comment docs.

@theunrepentantgeek theunrepentantgeek self-assigned this Jul 1, 2021
@theunrepentantgeek theunrepentantgeek added this to the codegen-alpha-1 milestone Jul 1, 2021
@theunrepentantgeek theunrepentantgeek merged commit fafcaca into master Jul 4, 2021
@theunrepentantgeek theunrepentantgeek deleted the improve/astbuilder-api branch July 4, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants