Implement the Convertible interface on resources and object types #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
theunrepentantgeek
force-pushed
the
feature/conversion-functions
branch
2 times, most recently
from
0b1cf72 to
15d53c3
Compare
babbageclunk
approved these changes
Jun 3, 2021
hack/generator/pkg/codegen/pipeline_json_serialization_test_cases.go
Outdated
Show resolved
Hide resolved
hack/generator/pkg/testcases/object_type_serialization_test_case.go
Outdated
Show resolved
Hide resolved
matthchr
requested changes
Jun 9, 2021
theunrepentantgeek
force-pushed
the
feature/conversion-functions
branch
3 times, most recently
from
8a5d3d7 to
9eebbf9
Compare
theunrepentantgeek
force-pushed
the
feature/conversion-functions
branch
from
632f9a5 to
1f957d6
Compare
…1534) * Move test case into dedicated package * Generate test cases for resources too * Implement TestCaseDefiner on ResourceType
theunrepentantgeek
force-pushed
the
feature/conversion-functions
branch
from
1f957d6 to
3568843
Compare
theunrepentantgeek
force-pushed
the
feature/persist-apiversions
branch
from
f36dd42 to
d2da249
Compare
This was referenced Jul 1, 2021
theunrepentantgeek
force-pushed
the
feature/persist-apiversions
branch
from
6d73203 to
7319ad2
Compare
4 tasks
theunrepentantgeek
force-pushed
the
feature/persist-apiversions
branch
from
74e3f6f to
3be33df
Compare
5 tasks
|
Closing this, as discussed, now that everything useful has been harvested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the property assignment functions already being generated to implement the
ConvertTo()andConvertFrom()methods required by theconversions.Convertibleinterface required by the controlle runtime.Closes #1478
What this PR does / why we need it:
Implementation of
Convertibleis required to allow conversion of custom resources between the nominated hub storage type and the versions requsted by consumers.How does this PR make you feel:
If applicable: