Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Property Assignment Function into the functions package #1622

Merged
merged 11 commits into from
Jul 8, 2021

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Jul 5, 2021

What this PR does / why we need it:

Moves PropertyAssignmentFunction into the functions package so that it's more discoverable and reusable. Required removing some functionality from the function so that it could stay in the conversions package to avoid circular references.

Reuse of this function is required by WIP to create a ConvertResourceFunction, necessary for implementing the Convertible interface.

Harvested from PR #1533

Prerequisites

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@theunrepentantgeek theunrepentantgeek self-assigned this Jul 5, 2021
@theunrepentantgeek theunrepentantgeek added this to the codegen-alpha-0 milestone Jul 5, 2021
@theunrepentantgeek theunrepentantgeek changed the title Add CreateErrorAndWrap() to astbuilder Move Property Assignment Function into the functions package Jul 5, 2021
@theunrepentantgeek theunrepentantgeek force-pushed the feature/move-property-assignment-function branch 2 times, most recently from 00c58fb to a62c011 Compare July 6, 2021 05:26
@theunrepentantgeek theunrepentantgeek force-pushed the feature/move-property-assignment-function branch 2 times, most recently from 4352807 to 1c75733 Compare July 7, 2021 03:18
Base automatically changed from improve/direction to master July 8, 2021 20:52
@theunrepentantgeek theunrepentantgeek force-pushed the feature/move-property-assignment-function branch from 1c75733 to fa329cf Compare July 8, 2021 21:03
@codecov-commenter
Copy link

Codecov Report

Merging #1622 (4531b89) into master (5e6b16b) will increase coverage by 0.00%.
The diff coverage is 89.79%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1622   +/-   ##
=======================================
  Coverage   64.88%   64.89%           
=======================================
  Files         203      203           
  Lines       12603    12614   +11     
=======================================
+ Hits         8178     8186    +8     
- Misses       3711     3715    +4     
+ Partials      714      713    -1     
Impacted Files Coverage Δ
hack/generator/pkg/astbuilder/builder.go 82.44% <0.00%> (-2.26%) ⬇️
...n/pipeline/inject_property_assignment_functions.go 66.66% <100.00%> (ø)
.../generator/pkg/conversions/property_conversions.go 78.89% <100.00%> (+0.21%) ⬆️
...or/pkg/conversions/readable_conversion_endpoint.go 96.66% <100.00%> (+3.33%) ⬆️
...or/pkg/conversions/writable_conversion_endpoint.go 95.23% <100.00%> (+3.57%) ⬆️
...ator/pkg/functions/property_assignment_function.go 76.98% <100.00%> (ø)
hack/generated/pkg/genruntime/resolver.go 84.74% <0.00%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6b16b...4531b89. Read the comment docs.

@theunrepentantgeek theunrepentantgeek merged commit e16e163 into master Jul 8, 2021
@theunrepentantgeek theunrepentantgeek deleted the feature/move-property-assignment-function branch July 8, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants