-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Property Assignment Function into the functions package #1622
Merged
theunrepentantgeek
merged 11 commits into
master
from
feature/move-property-assignment-function
Jul 8, 2021
Merged
Move Property Assignment Function into the functions package #1622
theunrepentantgeek
merged 11 commits into
master
from
feature/move-property-assignment-function
Jul 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
July 5, 2021 21:53
theunrepentantgeek
changed the title
Add CreateErrorAndWrap() to astbuilder
Move Property Assignment Function into the functions package
Jul 5, 2021
theunrepentantgeek
force-pushed
the
improve/direction
branch
from
July 6, 2021 03:56
78128e7
to
0865bf6
Compare
theunrepentantgeek
force-pushed
the
feature/move-property-assignment-function
branch
2 times, most recently
from
July 6, 2021 05:26
00c58fb
to
a62c011
Compare
theunrepentantgeek
force-pushed
the
improve/direction
branch
from
July 7, 2021 02:55
0865bf6
to
dc9c56f
Compare
theunrepentantgeek
force-pushed
the
feature/move-property-assignment-function
branch
2 times, most recently
from
July 7, 2021 03:18
4352807
to
1c75733
Compare
This was referenced Jul 7, 2021
babbageclunk
approved these changes
Jul 8, 2021
theunrepentantgeek
force-pushed
the
feature/move-property-assignment-function
branch
from
July 8, 2021 21:03
1c75733
to
fa329cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
=======================================
Coverage 64.88% 64.89%
=======================================
Files 203 203
Lines 12603 12614 +11
=======================================
+ Hits 8178 8186 +8
- Misses 3711 3715 +4
+ Partials 714 713 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves
PropertyAssignmentFunction
into thefunctions
package so that it's more discoverable and reusable. Required removing some functionality from the function so that it could stay in theconversions
package to avoid circular references.Reuse of this function is required by WIP to create a
ConvertResourceFunction
, necessary for implementing theConvertible
interface.Harvested from PR #1533
Prerequisites
master
How does this PR make you feel:
If applicable: