-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve flattening #1631
Merged
Merged
Improve flattening #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
requested review from
babbageclunk,
davefellows,
matthchr and
theunrepentantgeek
as code owners
July 7, 2021 22:27
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
+ Coverage 62.17% 64.65% +2.48%
==========================================
Files 163 203 +40
Lines 10739 12696 +1957
==========================================
+ Hits 6677 8209 +1532
- Misses 3422 3760 +338
- Partials 640 727 +87
Continue to review full report at Codecov.
|
matthchr
approved these changes
Jul 7, 2021
theunrepentantgeek
requested changes
Jul 8, 2021
theunrepentantgeek
approved these changes
Jul 8, 2021
This was referenced Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flatten: true
; improve reporting of panics during code generation process to include package/typename.required
attribute has been forgotten.