-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generated typenames #1591
Comments
Marking as |
1. Flattening needed to visit arrays, maps, etc to match up inner types. 2. Added a panic if we have missed flattening any properties marked `flatten: true`; improve reporting of panics during code generation process to include package/typename. 3. If types are not modified then keep using the original type. This improves the typenames a bit (#1591). 4. When matching up spec/status types to augment specs with status, ignore any optionality when matching up types. This makes things work properly with the handcrafted schemas where often the `required` attribute has been forgotten.
From #1459: Consider performing the pluralization improvements step for spec and status of resources too. |
Whether we still need to do this depends on the results of #1758. |
Still need to do this, but not critical because we don't give code-dependency guarantees right now |
Type names are significantly improved by #2323 so I'm closing this. |
Describe the current behavior
See: #1548 (comment)
Includes depluralization of parent type names when creating type names for subresources.
The text was updated successfully, but these errors were encountered: