Added a new operator for SQL Firewall Rules, cleaned up the resource client #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamMortlMicrosoft
requested review from
frodopwns,
melonrush13 and
jananivMS
|
@frodopwns @jananivMS I added a bunch of comments explaining the code - let me know if it helps! |
frodopwns
reviewed
Sep 26, 2019
frodopwns
reviewed
Sep 26, 2019
|
@frodopwns resource group is no longer in the YAML... I tested the changes using the same criteria and things look good - please verify |
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Convert path to canonical form for exclusion check * Convert path to canonical form before parsing * Add tests for Windows paths * Only test Windows paths on Windows
matthchr
added a commit
to matthchr/azure-service-operator
that referenced
this pull request
Jul 19, 2022
This was caused by a manual error when creating the Helm chart. In the future, that error will not happen as we have automation to publish the chart. In beta.1's case, that automation failed because of a bug that is now fixed so the chart was published manually. Fixes Azure#239
matthchr
added a commit
to matthchr/azure-service-operator
that referenced
this pull request
Jul 19, 2022
This was caused by a manual error when creating the Helm chart. In the future, that error will not happen as we have automation to publish the chart. In beta.1's case, that automation failed because of a bug that is now fixed so the chart was published manually. Fixes Azure#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a new operator for SQL Firewall Rules. It was tested in the following scenarios:
-Add a new firewall rule and delete it
-Add a new firewall rule and then delete the sql server and make sure that it is deleted properly
Cleaned up the sql server resource client
Special notes for your reviewer:
If applicable: