Fix Helm chart installing CRDs twice #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
Porges,
babbageclunk and
super-harsh
as code owners
This was caused by a manual error when creating the Helm chart. In the future, that error will not happen as we have automation to publish the chart. In beta.1's case, that automation failed because of a bug that is now fixed so the chart was published manually. Fixes Azure#239
matthchr
force-pushed
the
feature/aso-beta1-helm-fix2
branch
from
1eac9d6 to
c03ef78
Compare
|
/ok-to-test sha=c03ef78 |
Codecov Report
@@ Coverage Diff @@
## main #2394 +/- ##
=======================================
Coverage ? 52.87%
=======================================
Files ? 884
Lines ? 275173
Branches ? 0
=======================================
Hits ? 145494
Misses ? 109088
Partials ? 20591 Continue to review full report at Codecov.
|
theunrepentantgeek
approved these changes
Jul 19, 2022
|
Closing as this has been superseded by the automated PR #2405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by a manual error when creating the Helm chart. In the
future, that error will not happen as we have automation to publish the
chart. In beta.1's case, that automation failed because of a bug that is
now fixed so the chart was published manually.
Fixes #2390