Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net46, netcore3.1 to management SDK test project #1540

Closed
wants to merge 34 commits into from

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Jan 17, 2022

Some implementations on .net standard 2.0 and .net core app are different, so tests for all the frameworks are necessary.

@Y-Sindo Y-Sindo enabled auto-merge (squash) January 17, 2022 04:52
@Y-Sindo Y-Sindo force-pushed the dev branch 5 times, most recently from 960227c to 240c903 Compare June 29, 2022 09:08
@Y-Sindo
Copy link
Member Author

Y-Sindo commented Jul 2, 2022

A lot of tests failed in Ubuntu and OSX after modifying the CI. It's hard to find out the root cause.
For example,

[xUnit.net 00:00:16.62]     Microsoft.Azure.SignalR.Common.Tests.BackOffPolicyFacts.FirstProbeThrowsTest [FAIL]
[xUnit.net 00:00:13.07]     Microsoft.Azure.SignalR.Tests.ServiceMessageTests.TestCloseConnectionMessageWithMigrateOut [FAIL] (After double the timeout )
PreviouslyUsedServiceConnectionsNotLeakedAfterHotReload2

@Y-Sindo Y-Sindo closed this Jul 2, 2022
@vicancy vicancy reopened this Aug 29, 2022
terencefan and others added 12 commits September 2, 2022 15:16
* Update Actions to use dotnet build (Azure#1663)

* Update windows.yml

* Add configurable options (Azure#1654)

* Update CI to enable net7.0 preview builds (Azure#1677)

* Support net7.0

* update osx/ubuntu.

* revert common package upgrade.

* update build-source guide and revert net7.0 in src.

* Add OrTimeout()

* Fix build warnings and add net6 samples (Azure#1676)

* Fix build warning

* Update docs

* Fix build failure

* Fix test failure

* Fix vlunerability issue (Azure#1678)

* Fix vlunerability issue

* fix filters

* fix filters

* Update use-signalr-service.md (Azure#1683)

* Change emulator to net6.0 (Azure#1682)

* Change emulator to net6.0

* Fix test

* Add filter property...... (Azure#1686)

* Add filter

* Add multiPayload case

* Adding comments

* Update management-sdk-guide.md (Azure#1689)

Improve a confusing statement. The original statement can also be interpreted as this SDK only supports SignalR clients based on ASP.NET Core C#, which confuses users. Azure#1688

* Expose InstanceId in ClientConnectionContext (Azure#1692)

* Fix `HubConnectionContext.UserIdentifier` is null when negotiation with Management SDK (Azure#1691)

When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK.

To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id.

The following code is the injection point.
https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141

Fixes Azure#1679

* Add ClientInvocationManager (Azure#1684)

* add ClientInvocationManager

* update CallerClientResultsManager (Azure#1697)

add `TryCompleteResult` for `ErrorCompletionMessage`

* Implement close on client authentication expiration (Azure#1699)

* Add spec for client-invocation. (Azure#1701)

* Add spec for client-invocation.

* minor update direction for ErrorCompletionMessage

* Add client Invocation implementation and UTs (Azure#1687)

* Add client Invocation implementation and UTs

* [ClientInvocation] Fix cleanup in caller case. (Azure#1702)

* Fix cleanup in caller case.

* fix UT.

* Update src/Microsoft.Azure.SignalR.Common/ClientInvocation/IClientInvocationManager.cs

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>

* Add ClientResultSample (Azure#1703)

* Add ClientResultSample

* Move file

* minor update.

* minor update README.

* show server/service ex.message

* Add Broadcast method and update README

* Fix proxy not applied to serverless transient mode (Azure#1708)

Fix Azure#1700

* silent IDE0090 check (Azure#1709)

* reduce retry interval when auth failed (Azure#1451)

* Clean up dependencies. (Azure#1711)

* Update dep to GA version.

* clean up dependencies

* clean management.

* fix test dep.

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
Co-authored-by: Kevin Guo <105208143+kevinguo-ed@users.noreply.github.com>
Co-authored-by: yzt <zityang@microsoft.com>
Co-authored-by: Eric Xing <87063252+xingsy97@users.noreply.github.com>
Co-authored-by: Terence Fan <stdrickforce@gmail.com>
Y-Sindo and others added 21 commits January 6, 2023 16:01
* Add echo in ServiceProtocol. (Azure#1829)

* Partial support client results in sharding mode. (Azure#1828)

* Partial support client results in sharding mode.

* limit single to avoid timeout waiting.

* Better information.

* update doc

* fix count.

* better exception information.

* Update version.props (Azure#1830)

---------

Co-authored-by: Zhenghui Yan <vwxyzh@gmail.com>
Release v1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants