Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SDK calls to the getAppObjectId function #260

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Added SDK calls to the getAppObjectId function #260

merged 11 commits into from
Apr 25, 2024

Conversation

Vidya2606
Copy link
Contributor

Description

Migrating getAppObjectId function from using the Azure CLI calls to SDK calls from azure-sdk-for-go.

Screenshot 2024-03-28 at 11 45 25 AM

Fixes # (issue)

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing reviewed Mar 28, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

davidgamero
davidgamero requested changes Apr 19, 2024
View reviewed changes
pkg/providers/az-client.go Outdated Show resolved Hide resolved
pkg/providers/az-client.go Show resolved Hide resolved
pkg/providers/az-client.go Outdated Show resolved Hide resolved
pkg/providers/az-client.go Outdated Show resolved Hide resolved
OliverMKing
OliverMKing approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work!

@OliverMKing
Copy link
Contributor

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

@OliverMKing
Copy link
Contributor

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

why does Draft vendor? that's causing problems

@davidgamero
Copy link
Collaborator

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

why does Draft vendor? that's causing problems

this is a good question we may not need to vendor and then we can avoid these issues

@davidgamero
Copy link
Collaborator

#271 will unblock these tests

@davidgamero
Copy link
Collaborator

okay should work when the updated main tests finish

@Tatsinnit Tatsinnit added the enhancement New feature or request label Apr 25, 2024
Tatsinnit
Tatsinnit approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Vidya2606 nice!!

davidgamero
davidgamero approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit 7c9284c into Azure:main Apr 25, 2024
149 checks passed
@Vidya2606 Vidya2606 deleted the migrate_getAppObjectId branch April 25, 2024 20:29
@Vidya2606 Vidya2606 mentioned this pull request May 31, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverMKing OliverMKing OliverMKing approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@davidgamero davidgamero davidgamero approved these changes

Assignees

@Vidya2606 Vidya2606

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vidya2606 @OliverMKing @davidgamero @Tatsinnit