Add new rule: 1050 - ParameterLocationHasChanged; Change behavior of ChangedParameterOrder rule with regards to x-ms-parameter-location

[konrad-jamrozik]

Addresses:

• [Breaking Change][False positive] openapi-diff should filter out client parameters before checking parameter order azure-sdk-tools#7170

[konrad-jamrozik]

FYI @mikekistler @mikekistler there was a bug here for over 2 years (#218) where this:

curParameter.Extensions.TryGetValue("x-ms-long-running-operation", out var curParameterLocation);

should have been:

curParameter.Extensions.TryGetValue("x-ms-parameter-location", out var curParameterLocation);

But that is not all. There also was a bug where parameters whose order doesn't matter would cause false positives on parameters whose order matters but didn't actually change. That latter bug was just hidden by the former bug. I fixed all of that in this PR

[konrad-jamrozik]

@mikekistler can you review and approve?

• Comment 1: https://github.com/Azure/openapi-diff/pull/334/files#r1646885090
• Comment 2: https://github.com/Azure/openapi-diff/pull/334/files#r1646886636

[konrad-jamrozik]

@mikekistler I applied the changes per our chat. Please see the diff for all the changes. Notably:

• New rule: https://github.com/Azure/openapi-diff/blob/users/kojamroz/param_order/docs/rules/1050.md
• Unit test: public void ParameterLocationChanged()
• See my comment here

[konrad-jamrozik]

@mikekistler per the ParameterRemoved test I added, here the removal of the params named "path_param", "path_param_req", "query_param_req", "body_param_req" will result in RemovedRequiredParameter breaking change each, while removal of "body_param", "query_param" will result in RemovedOptionalParameter breaking change.

Notably:

• no ChangedParameterOrder breaking change will be reported.
• path_param is considered required even though the param itself is not marked as such.

[mikekistler]

Looks good! 👍

[konrad-jamrozik]

Pull Request 559774: Update @azure/oad to 0.10.11 + rush update

[konrad-jamrozik]

Deployed to Production:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9767803&view=results

Test PR:

• DO NOT MERGE: TEST PR. Update wayfind.json to test ParameterLocationHasChanged test-repo-billy/azure-rest-api-specs#3371