DO NOT MERGE: TEST PR. Update wayfind.json to test ParameterLocationHasChanged

[konrad-jamrozik]

Test if rule 1050 ParameterLocationHasChanged triggers. It was implemented by:

• Add new rule: 1050 - ParameterLocationHasChanged; Change behavior of ChangedParameterOrder rule with regards to x-ms-parameter-location Azure/openapi-diff#334

[openapi-pipeline-app-test]

Next Steps to Merge

Next steps that must be taken to merge this PR:

• ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
  To unblock this PR, follow the process at aka.ms/brch.
• ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

[openapi-pipeline-app-test]

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app-test]

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Creator	https://apiviewstagingtest.com/Assemblies/Review/2a9b4231903d447ca023dc3869e280f9?revisionId=fd480e7a3d86460185e23359033cb2ab

[openapi-pipeline-app-test]

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.12)	new version	base version
wayfind.json	2022-09-01-preview(a8f40f5)	2022-09-01-preview(main)

Rule	Message
❌ 1050 - ParameterLocationHasChanged	Parameter location has changed. Name: 'api-version'. In: 'Query'. Old location is method: 'False'. New location is method: 'True'. New: Creator/preview/2022-09-01-preview/wayfind.json#L279:9 Old: Creator/preview/2022-09-01-preview/wayfind.json#L279:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2022-09-preview	package-2022-09-preview(a8f40f5)	package-2022-09-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ PageableOperation	Based on the response model schema, operation 'Wayfinding_GetPath' might be pageable. Consider adding the x-ms-pageable extension. Location: Creator/preview/2022-09-01-preview/wayfind.json#L271
⚠️ PaginationResponse	Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Creator/preview/2022-09-01-preview/wayfind.json#L271
⚠️ ParameterDefaultNotAllowed	A required parameter should not specify a default value. Location: Creator/preview/2022-09-01-preview/wayfind.json#L283
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Creator/preview/2022-09-01-preview/wayfind.json#L318
⚠️ ErrorResponse	Error schema should define code and message properties as required. Location: Creator/preview/2022-09-01-preview/wayfind.json#L318
⚠️ ErrorResponse	Error response should contain a x-ms-error-code header. Location: Creator/preview/2022-09-01-preview/wayfind.json#L318

️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

[konrad-jamrozik]

Updating @azure/oad to 0.10.12:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9769013&view=results

[konrad-jamrozik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[konrad-jamrozik]

This should have reported failure instead of

detectBreakingChange: Prevented spurious failure of breaking change check. prKey: test-repo-billy/azure-rest-api-specs/3371, comparisonType: SameVersion, oadViolationsCnt: 1, process.exitCode: 0.

?

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3895887&view=logs&j=98f87804-8e1f-5655-af02-e80aefa7aa97&t=cc3a9482-d623-554e-0ea4-1b9ff4f5608e

That "spuriosity" check is there since:

• [Breaking Change][PR Workflow] Breaking Changes should not flag breaks from prior preview as errors Azure/azure-sdk-tools#6396

See also:

• https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/openapi-alps/pullRequest/559850#1719013715

[konrad-jamrozik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[konrad-jamrozik]

@mikekistler:

looking at this PR and this result: https://github.com/test-repo-billy/azure-rest-api-specs/pull/3371/checks?check_run_id=26540401459

according to this diagram:
https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-brch-deep#diagram-explaining-breaking-changes-and-versioning-issues

we are in the "same-version check / preview / breaking change" so automation should add VersioningReviewRequired label. Is my analysis correct?

[mikekistler]

Agreed. Should have VersioningReviewRequired.

[konrad-jamrozik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[konrad-jamrozik]

Agreed. Should have VersioningReviewRequired.

Pull Request 560333: breaking changes: Fix ParameterLocationHasChanged not triggering for "same-API" version check