feat: migrate test pipelines to gh #339
Conversation
| - name: pack | ||
| run: npm pack | ||
|
|
||
| - name: Copy Files to target-folder | ||
| run: mkdir -p ${{ matrix.target-folder }} && cp *.tgz ${{ matrix.target-folder }} | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: ${{ matrix.target-folder }} | ||
| path: ${{ matrix.target-folder }} |
There was a problem hiding this comment.
What is the benefit of doing npm pack and the remaining steps?
I think they may have made sense in the context of uploading tests results to Azure DevOps pipeline and/or publishing the package, but if we make this GH action go up to test and no later, will uploading artifacts help? Will it somehow integrate with GitHub UI for nice test viewing experience or similar? If not, perhaps we can remove it.
There was a problem hiding this comment.
Yes, it does!
Example here in a repo I also maintain: https://github.com/gitify-app/gitify/actions/runs/9626236252
You can see all of the artifacts of a given workflow, which is something that I'd say would be nice to keep!
| run: mkdir -p ${{ matrix.target-folder }} && cp *.tgz ${{ matrix.target-folder }} | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
The @v2 of actions/upload-artifact is deprecated since 6/30/2024, i.e. yesterday:
https://github.com/actions/upload-artifact#actionsupload-artifact
I can fix it in a future PR.
Fixes #330.
The last two steps I can't really replicate here as I am not sure how to replace it with, happy to change anything!