feat: migrate test pipelines to gh #339
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: ci | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| target-folder: drop-linux | ||
| - os: windows-latest | ||
| target-folder: drop | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "20" | ||
|
|
||
| - name: npm ci | ||
| run: npm ci | ||
|
|
||
| - name: lint | ||
| run: npm run lint | ||
|
|
||
| - name: prettier | ||
| run: npm run prettier | ||
|
|
||
| - name: test | ||
| run: npm test | ||
|
|
||
| - name: pack | ||
| run: npm pack | ||
|
|
||
| - name: Copy Files to target-folder | ||
| run: mkdir -p ${{ matrix.target-folder }} && cp *.tgz ${{ matrix.target-folder }} | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: ${{ matrix.target-folder }} | ||
| path: ${{ matrix.target-folder }} | ||
|
Comment on lines
+38
to
+48
There was a problem hiding this comment. What is the benefit of doing I think they may have made sense in the context of uploading tests results to Azure DevOps pipeline and/or publishing the package, but if we make this GH action go up to There was a problem hiding this comment. Yes, it does! Example here in a repo I also maintain: https://github.com/gitify-app/gitify/actions/runs/9626236252 You can see all of the artifacts of a given workflow, which is something that I'd say would be nice to keep! |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
@v2ofactions/upload-artifactis deprecated since 6/30/2024, i.e. yesterday:https://github.com/actions/upload-artifact#actionsupload-artifact
I can fix it in a future PR.