-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[voq/inbandif] Voq inbandif port #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoc-do
previously approved these changes
Feb 8, 2021
jleveque
force-pushed
the
master
branch
2 times, most recently
from
February 10, 2021 22:57
affe6be
to
c31636e
Compare
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
3 times, most recently
from
February 17, 2021 19:51
f1628fa
to
ffd4e17
Compare
abdosi
previously approved these changes
Mar 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
@ngoc-do - please re-approve |
ngoc-do
previously approved these changes
Mar 22, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 159 in repo Azure/sonic-platform-common |
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Inband port is avaialable in PORT table. But regular port handlings are not applicable for Inband port. Changes in this PR for avoiding regular port handling on Inband port.
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
April 7, 2021 23:54
ffd4e17
to
81e82f9
Compare
abdosi
approved these changes
Apr 9, 2021
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…s, omit the check inside hw_state table (sonic-net#159) This change essentially omits a look inside the state DB for HW_MUX_CABLE_TABLE and just directly goes to the muxcable eeprom to either toggle or remain Iin the same state as is requested from the incoming message from orchagent, and then write back to the DB Description This fix will help in debugging the initialization loop since now other modules will not be dependent on stale state present in HW_MUX_CABLE_TABLE. How Has This Been Tested? Tested on starlab testbed with integration of other modules Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inband port is avaialable in PORT table. But regular port handlings are
not applicable for Inband port. Changes in this PR for avoiding regular
port handling on Inband port.
This PR depends on sonic-buildimage PR sonic-net/sonic-buildimage#6477