[voq/inbandif] Support for inband port as regular port #6477
Conversation
|
@eswaran (Arista) - could you please review the PR, thanks. |
dockers/docker-lldp/lldpmgrd
Outdated
| @@ -94,6 +94,11 @@ class LldpManager(daemon_base.DaemonBase): | |||
| """ | |||
| port_desc = None | |||
|
|
|||
| # Skip port name prefixed with "Inband". These are recycle ports exposed in PORT_TABLE for | |||
| # asic-to-asic communication in VOQ based chassis system. We do not configure LLDP on these. | |||
| if 'Inband' in port_name: | |||
There was a problem hiding this comment.
Should it be port_name.startswith('Inband') to match only on prefix?
There was a problem hiding this comment.
As per Recycle port HLD PR discussion, it was recommended to use name starting with Ethernet. For inband interface, it will be Ethernet-Inband0. For recirc port it will be Ethernet-Recirc0. I'll change this to port_name.startswith("Ethernet-Inband") or use the inband_prefix() as recommended in next comment.
dockers/docker-lldp/lldpmgrd
Outdated
| @@ -94,6 +94,11 @@ class LldpManager(daemon_base.DaemonBase): | |||
| """ | |||
| port_desc = None | |||
|
|
|||
| # Skip port name prefixed with "Inband". These are recycle ports exposed in PORT_TABLE for | |||
| # asic-to-asic communication in VOQ based chassis system. We do not configure LLDP on these. | |||
| if 'Inband' in port_name: | |||
There was a problem hiding this comment.
Can you use inband_prefix() from sonic_py_common/interface.py?
There was a problem hiding this comment.
Yes. I'll fix this.
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
f4e211e to
fa47d32
Compare
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Inband port is avaialable in PORT table. But regular port handlings are not applicable for Inband port. Changes are to make lldp to consider Inband port and to avoid regular port handling on Inband port.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Fixed code review comments
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Changes to avoid LLDP config on Inband interface. Since port type inband interfaces are recycle ports (or may normal ports) used for asic-to-asic communication, LLDP is not configured on these interfaces.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> (1) Based on review comments Recyle port HLD (sonic-net/SONiC#742) the inband port name prefix is changed from Inband to "Ethernet-IB" similar to what we have for Ethernet-BP (Ethernet-Backplane) in multi-asic design. Changes are done in interface.py to handle this changed name (2) Code review comments fix for lldpmgrd
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
fa47d32 to
b513a1e
Compare
|
/Azurepipelines run |
|
Commenter does not have sufficient privileges for PR 6477 in repo Azure/sonic-buildimage |
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@abdosi, thanks for starting the Azurepipeline runs. Would you please complete review and approve so that we can merge? The PRs sonic-net/sonic-platform-common#159, sonic-net/sonic-platform-daemons#145 and sonic-net/sonic-utilities#1363 which you have already approved depend on this PR for build success. |
Changes in this PR are to make LLDP to consider Inband port and to avoid regular port handling on Inband port.
Changes in this PR are to make LLDP to consider Inband port and to avoid regular port handling on Inband port.
- Why I did it
Inband port can be made available in PORT table. But regular port handlngs are
not applicable for Inband port.
Changes in this PR are to make LLDP to consider Inband port and to avoid regular
port handling on Inband port.
Currently the Inband interface is used for VOQ chassis systems for asic to asic communications.
Ref: VOQ HLD https://github.com/Azure/SONiC/blob/master/doc/voq/voq_hld.md
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)