Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[voq/inbandif] Voq inbandif port #159

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

vganesan-nokia
Copy link
Contributor

Inband port is avaialable in PORT table. But regular port handlings are
not applicable for Inband port. Changes in this PR for avoiding regular
port handling on Inband port.

This PR depends on sonic-buildimage PR sonic-net/sonic-buildimage#6477

@anshuv-mfst
Copy link

@eswaran (Arista) , @abdosi - could you please review the PR, thanks.

ngoc-do
ngoc-do previously approved these changes Feb 8, 2021
@jleveque jleveque force-pushed the master branch 2 times, most recently from affe6be to c31636e Compare February 10, 2021 22:57
@vganesan-nokia vganesan-nokia force-pushed the voq-inbandif-port branch 3 times, most recently from f1628fa to ffd4e17 Compare February 17, 2021 19:51
abdosi
abdosi previously approved these changes Mar 7, 2021
Copy link
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdosi
Copy link
Contributor

abdosi commented Mar 7, 2021

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anshuv-mfst
Copy link

@ngoc-do - please re-approve

@anshuv-mfst
Copy link

@ngoc-do, @eswaranb - please re-approve.

ngoc-do
ngoc-do previously approved these changes Mar 22, 2021
@abdosi
Copy link
Contributor

abdosi commented Apr 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vganesan-nokia
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 159 in repo Azure/sonic-platform-common

@vganesan-nokia
Copy link
Contributor Author

Capturing approvals before rebasing

image

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

Inband port is avaialable in PORT table. But regular port handlings are
not applicable for Inband port. Changes in this PR for avoiding regular
port handling on Inband port.
@vganesan-nokia vganesan-nokia dismissed stale reviews from ngoc-do and abdosi via 81e82f9 April 7, 2021 23:54
@abdosi abdosi merged commit f4901a0 into sonic-net:master Apr 9, 2021
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…s, omit the check inside hw_state table (sonic-net#159)

This change essentially omits a look inside the state DB for HW_MUX_CABLE_TABLE and just directly goes to the muxcable
eeprom to either toggle or remain Iin the same state as is requested from the incoming message from orchagent, and then write back to the DB

Description
This fix will help in debugging the initialization loop since now other modules will not be dependent on stale state present in
HW_MUX_CABLE_TABLE.

How Has This Been Tested?
Tested on starlab testbed with integration of other modules


Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants