Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] LROs that don't return a model should not set sdkMethod.response.type #124

Closed
jhendrixMSFT opened this issue Jan 12, 2024 · 1 comment · Fixed by #559
Closed

[Bug] LROs that don't return a model should not set sdkMethod.response.type #124

jhendrixMSFT opened this issue Jan 12, 2024 · 1 comment · Fixed by #559
Assignees
@iscai-msft
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Jan 12, 2024 •
edited
Loading

For reference: https://github.com/Azure/cadl-ranch/blob/main/packages/cadl-ranch-specs/http/azure/core/lro/standard/main.tsp#L167

This is a DELETE which does not return a model. We can see that sdkMethod.operation.responses contains an OperationStatus response type which makes sense at the protocol level. However, we also see that sdkMethod.response.type is an OperationStatus model type which I don't think makes sense at the method level.
@jhendrixMSFT jhendrixMSFT added bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library labels Jan 12, 2024
@jhendrixMSFT
Copy link
Member Author

Related: #31

@iscai-msft iscai-msft mentioned this issue Apr 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2024
@iscai-msft @jhendrixMSFT @tadelesh
[tcgc] take lro finalResult into consideration (#559)
897ba80 
fixes #124

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
Co-authored-by: tadelesh <tadelesh.shi@live.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iscai-msft iscai-msft

Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tcgc] take lro finalResult into consideration Azure/typespec-azure
3 participants
@tadelesh @jhendrixMSFT @iscai-msft