Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] take lro finalResult into consideration #559

Merged
merged 12 commits into from
Apr 22, 2024
Merged

[tcgc] take lro finalResult into consideration #559

merged 12 commits into from
Apr 22, 2024

Conversation

iscai-msft
Copy link
Contributor

fixes #124

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 1, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

take lroMetadata.finalResult into consideration

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/559/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/559/

@iscai-msft iscai-msft enabled auto-merge (squash) April 1, 2024 15:52
@iscai-msft iscai-msft disabled auto-merge April 1, 2024 19:41
@iscai-msft iscai-msft enabled auto-merge (squash) April 1, 2024 19:41
jhendrixMSFT
jhendrixMSFT previously requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have introduced a regression. For https://github.com/Azure/cadl-ranch/blob/main/packages/cadl-ranch-specs/http/azure/core/lro/rpc-legacy/main.tsp#L148 the operation no longer has a return type.

auto-merge was automatically disabled April 2, 2024 22:44

Merge queue setting changed

@tadelesh
Copy link
Member

tadelesh commented Apr 3, 2024

This appears to have introduced a regression. For https://github.com/Azure/cadl-ranch/blob/main/packages/cadl-ranch-specs/http/azure/core/lro/rpc-legacy/main.tsp#L148 the operation no longer has a return type.

I do think it is a problem from getLroMetadata. @markcowl , could you help to identify why for this cadl-ranch test, we get void for finalResult?

@tadelesh tadelesh mentioned this pull request Apr 18, 2024
Closed
@jhendrixMSFT jhendrixMSFT dismissed their stale review April 22, 2024 18:03

change is expected

@iscai-msft iscai-msft added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 897ba80 Apr 22, 2024
21 checks passed
@iscai-msft iscai-msft deleted the lro_response branch April 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] LROs that don't return a model should not set sdkMethod.response.type
4 participants
@iscai-msft @azure-sdk @tadelesh @jhendrixMSFT