Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] remove unused path parameter from method #1775

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

tadelesh
Copy link
Member

fix: #1709
fix: #1728

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 31, 2024

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

  • @azure-tools/typespec-azure-resource-manager

The following packages have already been documented:

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

support serialized name for body parameter to avoid example mis-mapping

@azure-tools/typespec-client-generator-core - fix ✏️

use root source property to map operation params to method

@azure-tools/typespec-client-generator-core - fix ✏️

remove unused path parameter from method

@azure-tools/typespec-client-generator-core - breaking ✏️

We no longer filter out core models. The filter-out-core-models parameter to SdkContext is also removed

@azure-tools/typespec-client-generator-core - feature ✏️

make union/nullable type to be reference type and add usage/access support for them

@azure-tools/typespec-client-generator-core - internal ✏️

fix ci

@tadelesh tadelesh changed the title [tcgc] remove useless path parameter from method [tcgc] remove unused path parameter from method Oct 31, 2024
@tadelesh tadelesh changed the title [tcgc] remove unused path parameter from method [tcgc] remove un-used path parameter from method Oct 31, 2024
@tadelesh tadelesh changed the title [tcgc] remove un-used path parameter from method [tcgc] remove unused path parameter from method Oct 31, 2024
@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@iscai-msft iscai-msft enabled auto-merge (squash) October 31, 2024 15:09
@iscai-msft iscai-msft merged commit 76804d4 into release/october-2024 Oct 31, 2024
22 checks passed
@iscai-msft iscai-msft deleted the fix_route_param branch October 31, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants