This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Enable dynamic whitelisting of dSTS endpoints to support new buildouts #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add whitelist function so dsts hosts pass validation.
Adding unit test to test static instance discovery of dsts enpoints and validating of a dsts endpoint in AuthenticationContext.
Remove unnecessary white space, add documentation to whitelist, use self.fail in unit test.
Change dSTS host whitelisting to dynamic discovery of endpoints containing dsts.
Fix whitespace
Fix dSTS test endpoint value to correct format.
Fix dsts test endpoint.
rayluo
reviewed
Nov 13, 2019
Update whitelist funtion to only check for ".dsts." in url.
rayluo
reviewed
Nov 14, 2019
I am not sure about the details on this, we could have a conversation with Abhinav the dSTS lead to add dSTS support to MSAL. For now, this is a short term fix to support customers already using ADAL who need to deploy a new cloud environment. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dynamic whitelisting of dSTS endpoints to support new buildouts of national cloud environments.
UPDATED info quoted from PR conversation:
The new authority.py implementation for dSTS is to support (future) new cloud environments in which we will not be allowed to explicitly whitelist endpoints in public GitHub repos due to customer restrictions on releasing DNS names. Since I have removed dSTS whitelisting constants, these test cases should be sufficient to cover all current and future dSTS endpoints that fit the .dsts. DNS address pattern.