This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidnya13
commented
May 1, 2020
- Enhancement: Enabled dynamic whitelisting of dSTS endpoints (Enable dynamic whitelisting of dSTS endpoints to support new buildouts #215 )
- World wide authority updated from login.windows.net to login.microsoftonline.com (Removal of login.windows.net / login-us #227 )
Merge ADAL Python 1.2.2 release branch back to dev
#215) * Whitelisting dsts endpoints. * adding whitespace * changing back WORLD_WIDE_AUTHORITY * add whitelist function add whitelist function so dsts hosts pass validation. * Adding unit tests Adding unit test to test static instance discovery of dsts enpoints and validating of a dsts endpoint in AuthenticationContext. * fixed whitespace * fix syntax error * Fix whitespace * fix more spaces * Respond to PR comments Remove unnecessary white space, add documentation to whitelist, use self.fail in unit test. * Enable endpoint discovery Change dSTS host whitelisting to dynamic discovery of endpoints containing dsts. * Fix whitespace Fix whitespace * Update test_authority.py Fix dSTS test endpoint value to correct format. * Update test_authority.py Fix dsts test endpoint. * Update authority.py Update whitelist funtion to only check for ".dsts." in url.
Advertise MSAL Python in both README and API reference docs
Merge a patch back to dev branch
Nit on grammer
Login.windows.net needs to be replaced by login.microsoftonline.com. Also removing legacy US Gov endpoint that has been retired (login-us.microsoftonline.com)
Removing tests for login.windows.net and login-us. Added test for login.microsoftonline.us.
Removing the from the test that are hard coded.
Updating authrorityHostUrl to login.microsoftonline.com from login.windows.net
removing login.windows.net and replacing with login.microsoftonline.com
Updating to login.microsoftonline.com
Backport MSAL PR #185 to ADAL
Removal of login.windows.net / login-us
Bumping version number
rayluo
approved these changes
May 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.