[AutoPR azure-mgmt-resource] Fix minor issues in policy exemptions #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
…Azure#15816) * OpenTelemetry Exporter use Resources API to retrieve cloud role properties * lint * Adding changelog
* Move common code to create API review into eng common in tools
* Add keys migration guide, update keys README * Address feedback * Update language about local crypto
Co-authored-by: Tural Farhadov <tufarhad@microsoft.com>
…m certificate (Azure#15863) * Add certificate key/cert parsing samples * Thanks, Charles! * Better wording Co-authored-by: Charles Lowell <chlowe@microsoft.com>
echoing: Azure#15493 Py39 is native to the images now. Don't need to download and install it anymore. Accommodating for EH/SB
* [Storage][LiveTest]replace the fixed blob names * re-record
…te issue Azure#13546 having been fixed. (it seems to have been.) (Azure#15786) Co-authored-by: Yunhao Ling <adam_ling@outlook.com>
* Remove redundant decorators; skip managed identity test * add isasync optional param for get auth policy * Enable async managed identity test * Force decoding url in async client Co-authored-by: turalf <tufarhad@microsoft.com>
…ion (Azure#15393) * Generated using newest autorest version * readded version * readded StorageErrorException * added more missing imports for storageErrorException * added more missing imports for storageErrorException * use http_response * eradicated StorageErrorException * added http_response to deserialize * added http_response location mode * added body to params since it got repositioned * made more changes * added extra check * fixed sync test for retention policy * fixed async rentention policy test * fixed ci for blobs * generated for datalake using new gen * api versioning fix * removed storage error excep * fixed append data bug * fixed all failing tests for datalake * fixed all failing tests for datalake * linter * fixed linter * fixed linter * removed cls in datalake list paths * removed the cls method from deserialize * added version id
* removed unittest.main() from test files, small steps * goofed on the merge commit
* run black against codes * rever comment content * fix pylint * run black after merging from master * fix pylint * fix pylint * update tests.yml
* adding a test folder in docs, updating dev_setup.md to install from dev_requirements.txt * updating docs with new information, creating a tests folder. committing in the middle to switch gears * more updates to test documentation, adding section on writing tests for the data plane libraries * added a section on writing tests for non-mgmt libraries * adding a tests readme and intro guide, adding info about preparers * changing dev setup to install packages correctly * addressing all of laurents comments * those were kierans comments, moved examples over to the dev file * removing references to azure active directory * second read-through with more updates and clean ups * small updates * updating based on krista and laurents comments, moved mgmt settings stuff and preparers to an advanced section * updating based on izzy,krista, and laurents comments * comments from swathi and laurent * removed more sections about with 'tutorial' and added links to packaging
* updating packaging information * removing a duplicated line
* moved over to arm template, removing unnecessary stuff now * cleaning up files, removing unnecessary imports * fixed the user-agent issue, which has since dissappeared
* Update README to use a generalized link to unblock release * Update README.md * Update README.md
…age (Azure#16300) * initial commit: new folder for identity * Added root files to identity package * copy identity client files from admin to new pkg * add autorest generated files * copy samples over * update references in other packages * Added tests to identity package * remove identity code from admin package * update changelog * remove identity code from admin package * update changelog * Removed identity tests from admin package * Update admin readme * add back version.py for wheel generation * Removed user credential test in admin package * update _version.py * remove redundant files * fixed error with init file * minor naming fixes * only expose required shared models * Update chat to reference new identity package * Updated identity test recordings * Added examples to identity README.md * Updated dependencies in identity package * Updated code style to meet pylint requirements * Added identity package to ci file * Updated CHANGELOG version formatting Co-authored-by: Bert Ong <823691+beltr0n@users.noreply.github.com>
…zure#16334) * prefix appearance/style model with Text and expose models * add line appearance to sample with signature * feedback
* add function for getting existing package versions * Add SetPackageVersion function * Add GetPackageInstallNotes function
…Azure#16365) * move mindependency and latestdependency common pieces to eng/dependency_tools.txt
* Run the link verification step even previous step failed. * Make the tab right * Address comments * Run default condition if no RunOnFailure set. * Changed back to simple condition Co-authored-by: Sima Zhu <sizhu@microsoft.com>
* CodeGen from PR 12429 in Azure/azure-rest-api-specs Add new api-version 2020-08-01 of network to go sdk (Azure#12429) * test,version,CHANGELOG * fix changelog and version Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/12636/azure-mgmt-resource
branch
from
0bd2c24 to
22bd844
Compare
Removes unnecessary pylint statements, changes numbers to descriptions, makes a few code changes to address a pylint issue
* unexpose api_version property * update changelog
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/12636/azure-mgmt-resource
branch
from
22bd844 to
56f4f0b
Compare
* Update Change log in ACS packages * Address PR feedback
* commit -1 * async * lint * Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_helpers.py * Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_helpers.py * fix test * Update sdk/eventgrid/azure-eventgrid/tests/test_eg_publisher_client_async.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
* Fix sms client to adapt new phone number model * Fix async test Co-authored-by: turalf <tufarhad@microsoft.com>
* update pages description * missed a parentheses
* Added ContainerClient.exists() method * lint
* CodeGen from PR 12563 in Azure/azure-rest-api-specs Enable python track2 pipeline (Azure#12563) * test,version,CHANGELOG * fix test * fix changelog , version Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
… closure issue (Azure#16414) * Fixed Datalake Service Client context manager/session closure issue * test recording * removed redundant code
* track2 new pipeline * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * fix comment * better display ui
* Enforce API approval status for GA and include SDK type in package properties * Fix per review comment * Fixes as per review comments to avoid changing constructor signature * Fixes as per review comments to handle track 1 packages * Fix yaml format error Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Add cloud environment enum * Add cloud environemnt to CommunicationIdentifierModel * Rename CommunicationCloudEnvironment * Add cloud environemtn to serialize/deserialzie * Rearrange microsoft teams user class position * Rename the kwarg name * Add cloud env into tests * Fix typos in identifier kind enums * Add cloud to serialize/deserialize tests for teams user * remove unused import * Add identifier to the identifier to the microsoft teams user model * Add idenitifier to the phone number * Add ids to the tests * Make id mandatory for deserilize * Fix lint error * Add identifier to the doc string * Throw when identifier type is not supported * Fix typo in test name * Add test_serialize_foreign_throws * Add test for unknown kind * Fix docstring for serialize method * Fix the typo in anonymous * Fix phone number doc string * Sync model to admin and chat * Fix the docstring for CommunicationIdentifierModel * Remove dev-tools * add mgmt core to setup py for mgmt package * Update the core dependency in mgmt package. * Sync models to admin, sms, identity * Change the exception message * Add idnetifier check in the test * sync model to other packages * Remove unnecessary mgmt dependency * change identity to identifier in docstrings * change core forzen requirement for identity * Change docstring for sms * Override shared reqs for core * Fix forzen requirements for core and sms * change core dependency version in chat,sms,admin * Add mgmt core back to the dependency * Add a new line at the end of file Co-authored-by: turalf <tufarhad@microsoft.com>
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/12636/azure-mgmt-resource
branch
from
56f4f0b to
7d348b5
Compare
Merge 287d15fd770eb6cbff02a0679c0834fa10036a97 into c7358a0
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/12636/azure-mgmt-resource
branch
from
7d348b5 to
0dfffd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#12636
You can install the use using pip install of the artificats.