Chg(gha): python version to matrix of 3.6-11 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusjusjus
force-pushed
the
chg-version-311
branch
from
7ae1185
to
45dcca6
Compare
jusjusjus
commented
Aug 16, 2024
| @@ -14,17 +14,20 @@ jobs: | |||
| test_mffpy: | |||
| # Name the job | |||
| name: Lint and Test | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.6.7", "3.8", "3.9", "3.10", "3.11"] | |||
There was a problem hiding this comment.
here we add more versions
jusjusjus
commented
Aug 16, 2024
| @@ -85,7 +85,8 @@ def scale(self) -> float: | |||
| return self._scale | |||
|
|
|||
| def get_physical_samples(self, t0: float = 0.0, | |||
| dt: float = None, block_slice: slice = None, | |||
| dt: Optional[float] = None, | |||
| block_slice: Optional[slice] = None, | |||
There was a problem hiding this comment.
newer mypy switched default for implicit optional
jusjusjus
commented
Aug 16, 2024
| @@ -46,7 +46,7 @@ def test_devices(device): | |||
| locs = np.array([ | |||
| np.array([props['x'], props['y'], props['z']]) | |||
| for i, (_, props) in enumerate(coords.sensors.items()) | |||
| ], dtype=np.float) | |||
| ], dtype=np.float32) | |||
There was a problem hiding this comment.
np.float removed in numpy v1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #126 .
We haven't updated the versions of numpy (and python for that matter) appropriately. I reviewed the currently stable versions of python which is 3.8 through 11 and added these to the tests. I then performed changes accordingly. No code change should affect the functionality of mffpy since it's mostly adding type annotations.