Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose configuration keys as static variables in swift #125

Closed
DanielSumara opened this issue Feb 2, 2021 · 1 comment · Fixed by #201
Closed

Expose configuration keys as static variables in swift #125

DanielSumara opened this issue Feb 2, 2021 · 1 comment · Fixed by #201
Assignees
Milestone

Comments

@DanielSumara
Copy link

variants generate Variants structure for iOS project. This struct contains encrypted env variables which we can access in safe manner using eg. print(Variants. Secrets.propertyName). ENVIRONMENT VARIABLES

It would be great improvement if we could access in the same manner other defined properties instead using string as keys.

We can replace print(Variants.configuration["A_PROPERTY"]) using (Variants.configuration[.aProperty])

@gderaco gderaco added this to the Release 1.2.0 milestone Jul 25, 2022
@gderaco
Copy link
Contributor

gderaco commented Jul 25, 2022

Be sure to keep the old way to guarantee retrocompatibility

@romanhu-bb romanhu-bb self-assigned this Nov 23, 2022
arthurpalves added a commit that referenced this issue Oct 19, 2023
* FIX: Github Marketplace action not picking up the latest release automatically [#189]
* FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208]
* FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209]
* FIX: Some signing configurations not automatically set in Xcode 14 [#214]

* REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215]
* REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219]

* FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221]
* FEATURE:  Add ability to override app name per variant [#216]
* FEATURE: Expose configuration keys as static variables in swift [#125]
 
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: romanhu-bb <93975733+romanhu-bb@users.noreply.github.com>
Co-authored-by: Aksay Pudukudi Kandhadai (BB) <akshayp@backbase.com>
Co-authored-by: Divine Dube <dubedivine@gmail.com>
Co-authored-by: Nour Sandid <nour@backbase.com>
Co-authored-by: noursandidb <92526468+noursandidb@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Minucci <gabriel@minucci.com.br>
Co-authored-by: Alex Kuziaev <theperfectprogrammer@gmail.com>
arthurpalves added a commit that referenced this issue Oct 26, 2023
* FIX: Github Marketplace action not picking up the latest release automatically [#189]
* FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208]
* FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209]
* FIX: Some signing configurations not automatically set in Xcode 14 [#214]

* REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215]
* REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219]

* FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221]
* FEATURE:  Add ability to override app name per variant [#216]
* FEATURE: Expose configuration keys as static variables in swift [#125]
 
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: romanhu-bb <93975733+romanhu-bb@users.noreply.github.com>
Co-authored-by: Aksay Pudukudi Kandhadai (BB) <akshayp@backbase.com>
Co-authored-by: Divine Dube <dubedivine@gmail.com>
Co-authored-by: Nour Sandid <nour@backbase.com>
Co-authored-by: noursandidb <92526468+noursandidb@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Minucci <gabriel@minucci.com.br>
Co-authored-by: Alex Kuziaev <theperfectprogrammer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants