Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile #208

Closed
dubeboy opened this issue Jan 25, 2023 · 0 comments · Fixed by #212
Closed

Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile #208

dubeboy opened this issue Jan 25, 2023 · 0 comments · Fixed by #212
Labels
bug Something isn't working

Comments

@dubeboy
Copy link
Contributor

dubeboy commented Jan 25, 2023 •
edited
Loading

Environment

Variants:

  • Way of installation: make install, v3.6.18
  • Version: 1.1.3

Your machine:

  • OS: MacOS
  • Processor: Apple M1 Pro

Project's platform:

  • Platform: iOS

Describe the bug

After running variants setup the Gemfile defaults to 'cocoapods', '1.9.0' and gem 'nokogiri', '1.11.0' which has a problem installing on m1 mac, therefore bundle install fails with a hard to debug error. all you need to do is upgrade coacoapods to gem 'cocoapods', '1.11.3' and gem "nokogiri", ">= 1.13.5"

Steps to reproduce

  1. Create new iOS project
  2. Create variants.yml in root folder
  3. install Variants
  4. Execute command variants setup
  5. run bundle install
  6. See error

Expected behavior
Bundle install completes successfully
@dubeboy dubeboy added the bug Something isn't working label Jan 25, 2023
@dubeboy dubeboy changed the title Calling variants setup on M1 mac adds unsupported gems to Gemfile Calling variants setup on M1 mac uses M1 unsupported gems to Gemfile Jan 25, 2023
@dubeboy dubeboy changed the title Calling variants setup on M1 mac uses M1 unsupported gems to Gemfile Calling variants setup on M1 mac uses M1 unsupported in Gemfile Jan 25, 2023
@dubeboy dubeboy changed the title Calling variants setup on M1 mac uses M1 unsupported in Gemfile Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile Jan 25, 2023
@arthurpalves arthurpalves mentioned this issue Feb 17, 2023
Merged
7 tasks
arthurpalves added a commit that referenced this issue Oct 19, 2023
@arthurpalves
Release 1.2.0 (#232)
096ca0d 
* FIX: Github Marketplace action not picking up the latest release automatically [#189]
* FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208]
* FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209]
* FIX: Some signing configurations not automatically set in Xcode 14 [#214]

* REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215]
* REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219]

* FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221]
* FEATURE:  Add ability to override app name per variant [#216]
* FEATURE: Expose configuration keys as static variables in swift [#125]
 
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: romanhu-bb <93975733+romanhu-bb@users.noreply.github.com>
Co-authored-by: Aksay Pudukudi Kandhadai (BB) <akshayp@backbase.com>
Co-authored-by: Divine Dube <dubedivine@gmail.com>
Co-authored-by: Nour Sandid <nour@backbase.com>
Co-authored-by: noursandidb <92526468+noursandidb@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Minucci <gabriel@minucci.com.br>
Co-authored-by: Alex Kuziaev <theperfectprogrammer@gmail.com>
arthurpalves added a commit that referenced this issue Oct 26, 2023
@arthurpalves
Release 1.2.0 (#232) (#235)
13ea724 
* FIX: Github Marketplace action not picking up the latest release automatically [#189]
* FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208]
* FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209]
* FIX: Some signing configurations not automatically set in Xcode 14 [#214]

* REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215]
* REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219]

* FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221]
* FEATURE:  Add ability to override app name per variant [#216]
* FEATURE: Expose configuration keys as static variables in swift [#125]
 
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: romanhu-bb <93975733+romanhu-bb@users.noreply.github.com>
Co-authored-by: Aksay Pudukudi Kandhadai (BB) <akshayp@backbase.com>
Co-authored-by: Divine Dube <dubedivine@gmail.com>
Co-authored-by: Nour Sandid <nour@backbase.com>
Co-authored-by: noursandidb <92526468+noursandidb@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Minucci <gabriel@minucci.com.br>
Co-authored-by: Alex Kuziaev <theperfectprogrammer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[208] Update Gemfile gems dubeboy/variants
1 participant
@dubeboy