Support ambiguous conditioning on TransformedDistributions #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
added
enhancement
eb8680
force-pushed
the
eb-indexset-selection
branch
from
5537f46 to
c4e84dd
Compare
eb8680
force-pushed
the
eb-indexset-transform
branch
from
389b39a to
26369ac
Compare
eb8680
added
status:awaiting review
cscherrer
pushed a commit
that referenced
this pull request
Mar 16, 2023
* selection * all tests pass * remove xfail * nit * suppress warning * nit * rename selection handlers * Add reparameterizers for resolving conditioning ambiguity * move to counterfactual * rename factual_conditioning -> conditioning * configuration for deepscm * move hack into internals * Include obs weight * skip when not ambiguous * Squashed commit of the following: commit 6222760 Author: Eli <eli@basis.ai> Date: Wed Mar 1 10:05:05 2023 -0500 import commit fa2891d Author: Eli <eli@basis.ai> Date: Wed Mar 1 09:50:46 2023 -0500 simplify api by removing merge * Squashed commit of the following: commit b37fb99 Author: Eli <eli@basis.ai> Date: Wed Mar 1 10:22:43 2023 -0500 lint commit 6222760 Author: Eli <eli@basis.ai> Date: Wed Mar 1 10:05:05 2023 -0500 import commit fa2891d Author: Eli <eli@basis.ai> Date: Wed Mar 1 09:50:46 2023 -0500 simplify api by removing merge * lint * fix tests * remove debug * device inference * fix rebase * Rebase * small bug * separate out transform conditioning * docs * functions * docs * docstrings * lint * Add tests and refactor to make them pass * clean up test and docstring * rename base * Support ambiguous conditioning on TransformedDistributions (#108) * Add transform conditioning * incorporate changes * format * test file * docs * test passes * fix bug * refactor * move default strategy into handlers * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12. Blocking #70, which exercises this machinery. Blocked by #97.
Factored out of #97 to expedite review, since #97 made a temporarily breaking change to
MultiWorldCounterfactual.Tasks: