Add handlers for masking indexed random variables #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
added
refactor
status:WIP
eb8680
force-pushed
the
eb-indexset-multiworld
branch
from
b37fb99 to
5f2a25d
Compare
eb8680
force-pushed
the
eb-indexset-selection
branch
from
15337f8 to
0ada4ec
Compare
eb8680
force-pushed
the
eb-indexset-multiworld
branch
from
5f2a25d to
82b0b6a
Compare
eb8680
force-pushed
the
eb-indexset-selection
branch
2 times, most recently
from
d157b2a to
8d3ec11
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2 tasks
eb8680
added
status:awaiting review
eb8680
force-pushed
the
eb-indexset-selection
branch
from
5537f46 to
c4e84dd
Compare
eb8680
commented
Mar 13, 2023
This was referenced Mar 13, 2023
This was referenced Mar 15, 2023
Closed
Closed
* Add transform conditioning * incorporate changes * format * test file * docs * test passes * fix bug * refactor * move default strategy into handlers
cscherrer
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #80, #12.
Part of a series of PRs extracted from #92. Builds on #96.
This PR adds a cleaner, more general implementation of the functionality for assigning a different default meaning to observation in the presence of counterfactuals that was temporarily removed in #96.
Remaining tasks:
dtypeanddevicesetting logic from Use correct devices in tensor creation in MultiWorldCounterfactual #74 toindexset_as_maskand add regression testTested:
test_mediation.py, e.g.test_mediation.py::test_mediation_nde_smoke