Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct escaping of avatar URL, update tests #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-bezero
Copy link

Bring in improvements from go-pkgz#184

notably:

  • avatar URLs are now correctly escaped if the user ID contains special characters such as &
  • tests have been updated
  • email fields are no-longer double-encoded

@david-bezero david-bezero mentioned this pull request Oct 30, 2023
@david-bezero
Copy link
Author

looks like the upstream PR might get merged at some point, so I'll hold off on merging these changes in favour of another upstream merge a bit later (we don't currently use these features anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants