forked from alek-sys/auth
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioutil is a deprecated module, and assert.NoError makes test error messages formatting more clear. Also, bump golangci-lint and fix the error "G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server"
It was already the case but never checked.
Previously a panic was generated with wrong key type: ``` panic: runtime error: invalid memory address or nil pointer dereference [recovered] ```
* Fix nil ptr panic in auth.go It happens when `err=nil` and `claims.User=nil` in Handlers() func. * Update auth.go by @Zhomart
Previously the form escaped the return URL twice, preventing it from working.
Also, add golangci-lint run for the _example module.
by @boryashkin * Pass bearer token * Pass bearer token: pass a state (cid) to be able to differentiate tokens between multiple sessions * Pass bearer token: pass a token.User to bearerTokenHook as the only option to link up code * Pass bearer token: add provider name to differentiate tokens * Pass bearer token: added tests * Pass bearer token: moved BearerTokenHook declaration down * Pass bearer token: named hook params, fixed possibility of nil pointer
Fixed that gravatar doesn't updated at login sometimes
* prep migration to go 1.20, update deps * update examples * lint: update linter config, suppress false-positives on test servers * fix gravatar test * address mongo-related tests * fix auth test with apple's GET * handle dbl close on gridfs, allows calling it multiple times * change ip for bad mongo store to fail for real * make store tests named * fix data race in telegram test --------- Co-authored-by: Dmitry Verkhoturov <paskal.07@gmail.com>
The reason is likely slow work of goroutines due to limited CPU.
Update based on my experience going through them.
…gz#163) * Add possibility to get additional user data * Fix linting * lint: fix comment --------- Co-authored-by: Umputun <umputun@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0. - [Commits](golang/net@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
alek-sys
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in commits since November 2022
Notably go-pkgz@cea049c which ensures users cannot continue to gain access through an old provider (also required a small modification to the test for oauth2 user login)
Skips some email safety checks to avoid conflicts with #2 (but we don't use that code anyway)
go fmt ./... && golangci-lint run && go test ./...
all pass.go mod tidy
has been run.