-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH, API: Remove "key" and "name" parameters #84
Conversation
The
It looks like this can be fixed by adding the I've already added the secret so I'll go ahead and open a new PR to update the YAML. |
* Remove the "key" and "name" parameters from all functions in `calculations.py`. Edge weights are now stored under a standard attribute name `weight`. For functions requiring the variable names (i.e. "k12") the strings are simply created on the fly using the available edge data. * Update `graph_utils.retrieve_rate_matrix` to use `NetworkX.to_numpy_array`. * Update function calls in `test_kda.py` to reflect parameter changes * Fix `diagrams.enumerate_partial_diagrams` to build the adjacency matrix without retrieving the edge weights from the diagram * Fix issue #56
489a8e9
to
85f1100
Compare
Okay, now that |
* Remove `graph_utils.generate_K_string_matrix` since it is no longer necessary for generating kinetic diagrams
The only thing left to do would be to update the root |
Description
Remove the
key
andnames
parameters fromall functions in
calculations.py
. Edgeweights are now stored under a standard
attribute name
weight
. For functionsrequiring the variable names (i.e. "k12") the
strings are simply created on the fly using
the available edge data.
Remove checks in
calculations.py
functionsfor
key
/output_strings
mismatches as wellas the test,
test_kda.test_function_inputs
, whichchecked
TypeError
s were raised at appropriatetimes
Remove
names
,val_key
,name_key
parameters fromgraph_utils.generate_edges
, as well as the associate testtest_generate_edges_errors
which checked the inputparameters raised
TypeErrors
at appropriate timesRemove
graph_utils.generate_K_string_matrix
since it is no longer necessary for generating
kinetic diagrams
Update documentation for all functions
to reflect parameter changes
Fix
diagrams.enumerate_partial_diagrams
to buildthe adjacency matrix without retrieving the edge
weights from the diagram
Update
graph_utils.retrieve_rate_matrix
to use
NetworkX.to_numpy_array
Update function calls in
test_kda.py
to reflect parameter changes
Fix issue ENH: Change graphs to store rates as edge weights instead of attributes #56
Status